[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: A wrong assert in get_ioreq()?


  • To: Paul Samon <paul.samon@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Wed, 04 Jul 2007 14:22:23 +0100
  • Delivery-date: Wed, 04 Jul 2007 06:20:34 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Ace+PlsomZh0PioxEdylUAAX8io7RQ==
  • Thread-topic: [Xen-devel] Re: A wrong assert in get_ioreq()?

The lock is taken in, for example, hvm_vcpu_initialise(), which calles get_ioreq(v) with v!=current. So the assertion is correct as-is.

 -- Keir

On 4/7/07 12:12, "Paul Samon" <paul.samon@xxxxxxxxx> wrote:

Sorry, I meant the assert should "ASSERT(v == current)."
 
On 7/4/07, Paul Samon <paul.samon@xxxxxxxxx> wrote:
I don't think it should be
    ASSERT(v == current).
we don't get the lock first, and I think we needn't it.
 
Am I missing something?
 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.