Re: [Xen-devel] Re: A wrong assert in get_ioreq()?

["Paul Samon" <paul.samon@xxxxxxxxx>]

Yes, the lock is necessary (for hvm_vcpu_initialise()), but my question is: in the ASSERT of get_ioreq(), we shouldn't check if we have got the lock, and we don't have the lock in it (if I'm wrong, please point out where we get the lock), that is, in get_ioreq(), I think  spin_is_locked(&d-> arch.hvm_domain.ioreq.lock) always returns false.

 

-- Paul S.

 

On 7/4/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote:

The lock is taken in, for example, hvm_vcpu_initialise(), which calles get_ioreq(v) with v!=current. So the assertion is correct as-is.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel