Re: [Xen-devel] [PATCH][TOOLS] libfsimage: portability fixes

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Thu, Mar 27, 2008 at 03:36:45PM +0000, Ian Jackson wrote:

> Christoph Egger writes ("Re: [Xen-devel] [PATCH][TOOLS] libfsimage: 
> portability fixes"):
> > Everytime when I submitted a patch where I changed /bin/bash to /bin/sh
> > John Levon came up with a "Build is broken on Solaris" message.
> > The fix was always the same: Use $(SHELL) as this is explicitely set for
> > Solaris.
> 
> People whose /bin/sh is that badly broken deserve to lose IMO - that

Putting it mildly, I don't think that disabling an important platform
because you have a bee in your bonnet about $(SHELL) is a sensible
implementation choice.

john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel