Re: [Xen-devel] pv_ops dom0 kernel failure with ata_piix / irq problems

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Pasi Kärkkäinen wrote:
> rc = devm_request_irq(dev, ATA_PRIMARY_IRQ(pdev), irq_handler, IRQF_SHARED, 
> drv_name, host);
> if (rc)
>         goto out;
>
> and ports names never get assigned because that "goto out;" is executed.
>
> So.. Any ideas why devm_request_irq() fails? 

Good question.  Will need to pick through

Hm, wonder if its something to do with the handling of the legacy irqs:

ata_pci_sff_activate_host: pci_read_config_byte()
ata_pci_sff_activate_host: if (!devres_open_group(dev, NULL, GFP_KERNEL))
ata_pci_sff_activate_host: if (!legacy_mode && pdev->irq)
ata_pci_sff_activate_host: legacy_mode
ata_pci_sff_activate_host: port 0 not dummy: devm_request_irq()
ata_pci_sff_activate_host: non-legacy-mode irq: 30
ata_pci_sff_activate_host: requesting ATA_PRIMARY_IRQ(pdev) irq: 14
ata_pci_sff_activate_host: devm_request_irq() returned != 0, goto out
ata_pci_sff_activate_host: out
ata_pci_sff_activate_host: devres_release_group()
ata_pci_sff_activate_host: end, returning


   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel