[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: spinlock requests (was RE: [Xen-devel] [Patch] don't spin with irq disabled)

On 31/03/2009 20:00, "Jeremy Fitzhardinge" <jeremy@xxxxxxxx> wrote:

>> If we care that much about fairness we should use ticket- or queue-based
>> locks. I don't believe any of our locks are contended enough to be a
>> concern. If they were, that would be a concern in itself.
> Writer vs reader fairness in rwlocks is different from normal spinlock
> fairness.  One presumes that you're expecting to get multiple readers if
> you choose to use a rwlock, but that can end up excluding writers for an
> unbounded amount of time.

I suspect the existing uses of rwlock in Xen actually are because that
seemed a natural fit for the code -- obvious split between reader and writer
critical sections -- rather than because of excessive serialisation if using
a normal spinlock. I strongly disbelieve that lock acquire/release is a
significant performance bottleneck for us right now.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.