Re: [Xen-devel] [PATCH v1 2/8]: PVH mmu changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2012-10-04 at 19:27 +0100, Mukesh Rathor wrote:
> On Thu, 4 Oct 2012 09:27:59 +0100
> Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Wed, 2012-10-03 at 23:29 +0100, Mukesh Rathor wrote:
> > > On Wed, 3 Oct 2012 16:42:43 +0100
> > > Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> > > 
> > > > 
> > > > >  int xen_remap_domain_mfn_range(struct vm_area_struct *vma,
> > > > >                              unsigned long addr,
> > > > >                              unsigned long mfn, int nr,
> > > > > -                            pgprot_t prot, unsigned domid);
> > > > > +                            pgprot_t prot, unsigned domid,
> > > > > +                            struct xen_pvh_pfn_info *pvhp);
> > > > > +int xen_unmap_domain_mfn_range(struct vm_area_struct *vma,
> > > > > +                            struct xen_pvh_pfn_info *pvhp);
> > > > > +
> > > > > +struct xen_pvh_pfn_info {
> > > > 
> > > > Can we call this xen_remap_mfn_info or something? PVH is x86
> > > > specific while this struct is also useful on ARM.
> > > 
> > > I already renamed it to: xen_xlat_pfn_info.
> > 
> > What does xlat refer to here? I don't think we translate anything with
> > this struct.
> 
> paging mode xlate! See stefanno's prev email where he suggested changing
> name to this.

Oh, because the uses are under XENFEAT_auto_translated_physmap? I
suppose that makes sense, kind of.

I guess it doesn't really matter since I reckon we can get rid of the
struct entirely anyway ;-)

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel