Re: [Xen-devel] [VTPM v6 6/8] Add autoconf to stubdom

["Fioravante, Matthew E." <Matthew.Fioravante@xxxxxxxxxx>]

AC_ARG_VAR just allows you to do CMAKE=foo ./configure. It also adds a message 
about the CMAKE variable when you do ./configure --help. I'm not convinced this 
half needs to be conditional.

The line that does the conditional check is the following:
AX_PATH_PROG_OR_FAIL_ARG([vtpm], [CMAKE], [cmake])

AX_PATH_PROG_OR_FAIL_ARG is a new macro I added to path_or_fail.m4. It does the 
same thing as AX_PATH_PROG_OR_FAIL if the first argument (in this case "$vtpm") 
is equal to "y". If the argument is anything else it sets the variable (in this 
case CMAKE) to NAME_disabled_in_configure_script.

The result is that if someone tries to build vtpm after disabling it they will 
get a rather loud and obvious error message cmake-disabled-in-configure-script: 
command not found.
________________________________________
________________________________________
From: Ian Campbell [Ian.Campbell@xxxxxxxxxx]
Sent: Wednesday, December 05, 2012 5:04 AM
To: Fioravante, Matthew E.
Cc: xen-devel@xxxxxxxxxxxxx; Ian Jackson
Subject: Re: [Xen-devel] [VTPM v6 6/8] Add autoconf to stubdom

On Tue, 2012-12-04 at 18:09 +0000, Matthew Fioravante wrote:
> +# Enable/disable stub domains
> +AX_STUBDOM_DEFAULT_ENABLE([ioemu-stubdom], [ioemu])
> +AX_STUBDOM_DEFAULT_DISABLE([c-stubdom], [c])
> +AX_STUBDOM_DEFAULT_ENABLE([caml-stubdom], [caml])
> +AX_STUBDOM_DEFAULT_ENABLE([pv-grub], [grub])
> +AX_STUBDOM_DEFAULT_ENABLE([xenstore-stubdom], [xenstore])
> +AX_STUBDOM_DEFAULT_ENABLE([vtpm-stubdom], [vtpm])
> +AX_STUBDOM_DEFAULT_ENABLE([vtpmmgrdom], [vtpmmgr])
> +
> +AX_ARG_DEFAULT_ENABLE([debug], [Disable debug build of stubdom])
> +AX_ARG_DEFAULT_ENABLE([extfiles], [Use xen extfiles repository for 
> libraries])
> +
> +AC_ARG_VAR([CMAKE], [Path to the cmake program])

Weren't you going to make vtpm* conditional on the presence of cmake? Or
is there some magic here which I don't understand?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel