Re: [Xen-devel] [PATCH 02/18] PVH xen: add XENMEM_add_to_physmap_range

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.06.13 at 17:08, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> Pardon my misunderstanding - what you are saying is that the location
> of this hypercall in arch_memory_op is correct - but only if it
> works with 32-bit guests as well?

Correct.

> Which would imply at least doing something in compat_arch_memory_op 
> (to copy the arguments properly),

Yes.

> and in the arch_memory_op
> return -ENOSYS if the guest is 32-bit (at least for right now).

No, or else the argument copying is pointless. In fact I don't think
arch_memory_op() needs any further tweaking for 32-bit guests
to work, it's solely the argument copying/translation that's missing.

> In the future the return -ENOSYS would be removed so that 32-bit
> guests can use this hypercall.
> 
> Or perhaps it make sense to squash the x86 and ARM version of this
> hypercall in the generic code? (later on)

That would be the ultimate goal, if feasible.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel