[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] Fix NULL pointer dereference in ARINC653 free_vdata.

On 03/11/13 23:01, Nate Studer wrote:
On 11/1/2013 10:13 AM, George Dunlap wrote:
Both these patches can have my Ack, BTW (although I don't think they
need it): I just wanted to be a good citizen and do a bit of review. :-)
Thanks Andrew and George.

Just to make sure, and to avoid needlessly filling George's inbox, Robbie (The
other ARINC653 scheduler maintainer) should usually be the one acking patches
like this, correct?

Oh, don't worry about filling up my inbox. I do want to know what's going on in the scheduling area, and I probably *should* review this kind of patch anyway. I was just saying, I don't think the committers necessarily need to wait for an Ack from me to commit it. :-)

I'm not sure exactly what the policy would be here -- I think the "need an ack from someone else" rule is primarily for committers to commit their own patches. If you're just submitting it, as a maintainer, it seems like having the committer look over it (and being satisfied that the community has had a chance to comment) should be enough, and needing an extra Ack from the other committer is a bit over-kill, particularly in this case.

But I could be wrong about that. :-)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.