[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] Call sched_destroy_domain before cpupool_rm_domain.

  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
  • Date: Thu, 07 Nov 2013 10:09:06 +0100
  • Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, Dario Faggioli <dario.faggioli@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Nate Studer <nate.studer@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxx
  • Delivery-date: Thu, 07 Nov 2013 10:00:45 +0000
  • Domainkey-signature: s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Message-ID:Date:From:Organization:User-Agent: MIME-Version:To:CC:Subject:References:In-Reply-To: Content-Type:Content-Transfer-Encoding; b=sosP4EaqSJvAKhMk+ivkXoTi2Mvu5kl19cyNjSxcgzVIeCtc8Z/MuUlc PIaIPyjcPXwKEzJYsLXGYFtSWeP1x/lcB2EzdKjovp/hMGBnr90mqnpMu PzYeyW11672pqCdR5/znM3iOoMUk9wPjVguAo9KomDlaFzrH0R127WszF t7VMjgejxydRAyx10Ipl0rTI/ABSC7fUnaeA6iPxu1IaJ09Nkf9XLGn2E 9a+vyxGrNL0uBYZUPVBW8dnjR8CTL;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

On 07.11.2013 08:39, Jan Beulich wrote:
On 05.11.13 at 06:59, Juergen Gross <juergen.gross@xxxxxxxxxxxxxx> wrote:
On 04.11.2013 16:22, Nate Studer wrote:
On 11/4/2013 4:58 AM, Juergen Gross wrote:
All other schedulers will just call xfree() for the domain specific data (and
may be update some statistic data, which is not critical).

The credit and credit2 schedulers do a bit more than that in their free_domdata

Sorry, got not enough sleep on the weekend ;-)

I checked only 4.1 and 4.2 trees. There only xfree of the domain data is

The credit scheduler frees the node_affinity_cpumask contained in the domain
data and the credit2 scheduler deletes a list element contained in the domain
data.  Since with this bug they are accessing structures that do not belong to
them, bad things happen.

So the patch would be subject to a 4.3 backport, I think.

Hmm, I'm slightly confused: credit2's free_domdata has always been
doing more than just xfree() afaict, and hence backporting is either
necessary uniformly or (taking into account that it was made clear
that arinc doesn't work with CPU pools anyway so far) not at all.

Please clarify.

Okay, I assumed only "production ready" features are to be taken into account
for a backport. And credit2 is clearly not in this state, or am I wrong?

A 4.3 backport should be considered in any case, as sedf and credit schedulers
behave differently in free_domdata, and both are "production ready". If you
want to be safe for credit2 and/or arinc653 as well, backports to 4.2 and 4.1
will be required.

In any case a backport isn't very complex. :-)


Juergen Gross                 Principal Developer Operating Systems
PBG PDG ES&S SWE OS6                   Telephone: +49 (0) 89 62060 2932
Fujitsu                                   e-mail: juergen.gross@xxxxxxxxxxxxxx
Mies-van-der-Rohe-Str. 8                Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.