Re: [Xen-devel] [PATCH 1 of 1] Update ZFS sources from illumos.org:

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-11-11 at 21:31 +0400, Igor Kozhukhov wrote:
> 
> On Nov 11, 2013, at 9:23 PM, Ian Campbell wrote:
> 
> > 
> > On Mon, 2013-11-11 at 21:16 +0400, Igor Kozhukhov wrote:
> >> Hi Ian,
> >> 
> >> we can use:
> >> https://github.com/illumos/illumos-gate/tree/master/usr/src/grub@2acef22db7808606888f8f92715629ff3ba555b9
> >> 
> >> will it be correct ?
> >> change set after '@'
> > 
> > That link is 404 for me.
> > 
> Could you please let me know how to get URL+changes et on GITHUB or another 
> version control system ?
> my URL contain:
> main URL: https://github.com/illumos/illumos-gate/tree/master/usr/src/grub
> changeset: 2acef22db7808606888f8f92715629ff3ba555b9
> 
> for compare with next updates if needed.

Just saying it in words is fine (changeset 2aceetcetc from
https://github/...etcetc).

> >> about -Werror
> >> 
> >> by GCC specific, if we want to disable some warnings we should add rules 
> >> after -Werror.
> >> example:
> >> -Werror -Wno-parentheses -Wno-unused
> >> 
> >> if we add rules "-Wno-parentheses -Wno-unused" before "-Werror" - they 
> >> will be ignored and we will have build problem.
> > 
> > Are you sure? We have at least some instances of this in our tree
> > already and it doesn't seem to be having any adverse impact.
> > 
> > The Werror docs don't say anything about this requirement, just "Make
> > all warnings into errors.". Since Werror doesn't actually enable or
> > disable any warnings itself I can't see why the ordering would matter.
> > 
> Yes - i'm sure. I have tested my changes with my rules before
> "-Werror" - they was ignored and i can see build issues. I have tested
> by gcc44 and gcc47.

How odd. Are you sure it is the position relative to Werror which
matters and not e.g. -Wall ?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel