Re: [Xen-devel] [PATCH 2/3] arinc: Add cpu-pool support to scheduler.

[Nate Studer <nate.studer@xxxxxxxxxxxxxxx>]

On 11/19/2013 6:33 AM, Andrew Cooper wrote:
> On 19/11/2013 11:18, George Dunlap wrote:
>> On 11/19/2013 10:30 AM, Andrew Cooper wrote:
>>> On 18/11/2013 20:16, Nathan Studer wrote:
>>>> @@ -450,7 +454,7 @@ a653sched_alloc_pdata(const struct scheduler
>>>> *ops, int cpu)
>>>>   static void
>>>>   a653sched_free_pdata(const struct scheduler *ops, void *pcpu, int
>>>> cpu)
>>>>   {
>>>> -    /* nop */
>>>> +    /* NOP */
>>>
>>> This change seems a little pointless.
>>
>> So is this criticism.  If the maintainer thinks the comment would look
>> better upper-case, he can change it.
>>
>>  -George
> 
> Sorry - I did not intend for this to come across as a criticism.  It is
> of course the maintainers prerogative as to which case he likes his
> comments in.
> 
> It is also a seemingly random and unrelated change to the purpose of the
> patch, and therefore open to query under our guidelines for patches.
> 
> http://wiki.xen.org/wiki/Submitting_Xen_Patches#Break_down_your_patches
> 
> ~Andrew
> 

While I do actually prefer lowercase, I did not intend to change the comment.
I'll remove this change in the next spin of the patches.

Thanks for keeping me honest, Andrew.

     Nate

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel