Re: [Xen-devel] [PATCH] libxl: introduce an option for disabling the non-O_DIRECT workaround [and 1 more messages]

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [Xen-devel] [PATCH] libxl: introduce an option for 
disabling the non-O_DIRECT workaround"):
> Not everyone builds her own kernel from the latest release; until we can 
> be relatively sure that this fix has hit distros (including older 
> LTS-style ones), we have to deal with the fact that the O_DIRECT bug may 
> be present.  The purpose of this flag is to enable you to turn it on 
> when you know it's safe -- for instance, if you're running a kernel with 
> this changeset.
> 
> It is worth asking the question now though: Given that this has been 
> checked in, would it make sense to switch the polarity of this -- 
> default to O_DIRECT on and have a flag to allow people to switch it off? 

Surely if the kernel has been fixed, libxl should detect this and turn
off the workaround automatically.   The kernel should expose something
that lets us tell.  (If nothing else, we can use the version number,
although that's really not ideal.)

I don't think it's a good idea to change the default, at least for
now.

But maybe the tristate is a reasonable suggestion.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel