[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/6] xen/iommu: Move dom0 setup code out of __init

>>> On 05.03.14 at 23:25, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> On 03/05/2014 04:56 AM, Jan Beulich wrote:
>>>>> On 04.03.14 at 23:51, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
>>> This is required to allow the hardware domain to be built by dom0 after
>>> the __init sections have been discarded.
>> Can you quantify the amount of code/data getting moved?
> It looks like about one page of code and very little data (fits in slack 
> space):

Anyway (and taking into consideration the rest of what you said)
I would lean towards asking for a special construct to accommodate
both your needs and the fact that likely most downstreams would
continue to build without XSM for a while - something along the
lines of Linux'es __init_or_module (i.e. in your case evaluating to
__init/__initdata when !XSM_ENABLE and to nothing in the opposite
case). Of course that's under the assumption that the rooting call
sites can be done reasonably cleanly wrt to making sure .init.*
references don't occur from normal code/data without being
properly guarded (mistakes here are rather difficult to track with
us not having a utility similar to Linux'es modpost checking section

And all that of course only unless others feel the movement out
of .init.* isn't that big a deal to invent special constructs for.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.