Re: [Xen-devel] [PATCH 4/6] xen: Allow hardare domain != dom0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.03.14 at 00:04, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> On 03/05/2014 05:04 AM, Jan Beulich wrote:
>>>>> On 04.03.14 at 23:51, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
>>> +
>>> +            dom0 = d;
>>
>> This, I think, is the point where the variable name becomes
>> intolerable: ASSERT(!dom0 || !dom0->domain_id) should be
>> valid at all times as long as the variable name is dom0.
> 
> I will prepare a pure rename patch prior to this one which
> renames the dom0 variable (and perhaps some functions with
> dom0 in their name) to another name: hwdom or hardware_domain
> would be my preference, with the hardware_dom global renamed
> to hardware_domid to avoid confusion.

Sounds reasonable.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel