Re: [Xen-devel] [PATCH 2/3] libxl: hotplug scripts: stdout >& stderr

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-18 at 18:12 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 2/3] libxl: hotplug scripts: stdout >& 
> stderr"):
> > On Tue, 2014-03-18 at 17:08 +0000, Ian Jackson wrote:
> > > Plumb hotplug scripts' stdout to stderr.  That way if they print
> > > anything (which really they shouldn't), it won't get mixed up with
> > > the application's stdout.  (Eg, perhaps with an xl migration
> > > stream...)
> ...
> > >      if (!pid) {
> > >          /* child */
> > > -        libxl__exec(gc, -1, -1, -1, args[0], args, env);
> > > +        libxl__exec(gc, -1, 2, -1, args[0], args, env);
> > 
> > Do you think we should also put the script's stderr to the application's
> > stderr?
> 
> I don't understand what you mean.  The scripts already inherit libxl's
> stderr.  Passing 2 as stderrfd would have no effect (libxl__exec would
> make a no-op call to dup2).

Sorry, I misremembered what -1 meant here.

> There is a bunch of stuff in the scripts themselves to try to do
> logging, which is mad and a swamp I'm choosing not to drain right now.

Right ;-)

> > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Thanks,
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel