Re: [Xen-devel] [PATCH 1/3] libxl: Make libxl_exec tolerate foofd<=2

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-03-18 at 18:14 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 1/3] libxl: Make libxl_exec tolerate 
> foofd<=2"):
> > On Tue, 2014-03-18 at 17:08 +0000, Ian Jackson wrote:
> > > Make passing 0, 1, or 2 as stdinfd, stdoutfd or stderrfd work
> > > properly.
> > > 
> > > Also, document the meaning of the fd arguments.
> ...
> > Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> > 
> > (consider s/2/STDERR_FILENO/ perhaps though?)
> 
> Urgh.  I detest STDERR_FILENO.  As if it would ever change.

True. I think of it as more a reading comprehension thing, by avoiding
the need to translate {0,1,2} in ones head, which isn't hard but does
introduce a pipeline stall, at least for me...

> > > + * stdinfd, stdoutfd, stderrfd will be dup2'd onto the corresponding
> > > + * fd in the child, if they are not -1.  The original copy of the
> > > + * descriptor will be closed in the child (unless it's 0, 1 or 2).
> > 
> > consider explicit mention of STD{IN,OUT,ERR} for the hard of
> > understanding?
> 
> I'll do that.
> 
> Thanks,
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel