[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 2/2] tools/console: xenconsole tolerate tty errors

On Tue, 2014-03-18 at 18:00 +0000, Ian Jackson wrote:
> Since 28d386fc4341 (XSA-57), libxl writes an empty value for the
> console tty node, with read-only permission for the guest, when
> setting up pv console "frontends".  (The actual tty value is later set
> by xenconsoled.)   Writing an empty node is not strictly necessary to
> stop the frontend from writing dangerous values here, but it is a good
> belt-and-braces approach.
> Unfortunately this confuses xenconsole.  It reads the empty value, and
> tries to open it as the tty.  xenconsole then exits.
> Fix this by having xenconsole treat an empty value the same way as no
> value at all.
> Also, make the error opening the tty be nonfatal: we just print a
> warning, but do not exit.  I think this is helpful in theoretical
> situations where xenconsole is racing with libxl and/or xenconsoled.
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.