Re: [Xen-devel] [PATCH OSSTEST v2 09/15] distros: add support for installing Debian PV guests via d-i, flight and jobs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 15:14 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST v2 09/15] distros: add support for 
> installing Debian PV guests via d-i, flight and jobs"):
> > On Fri, 2014-05-02 at 12:46 +0100, Ian Jackson wrote:
> > > Had you not noticed that you'd written out the store_runvars lines
> > > twice ?
> > 
> > The $netboot_foo are local in scope to within the two halves of the
> > if/else.
> 
> You can move declare them (with my) outside the if to fix this
> problem.  That's IMO much better than writing out those runvar stores
> twice.

OK.

> > > I think you want to use Osstest::Debian::di_installcmdline_core.
> > 
> > I think I do too, thanks for the pointer.
> > 
> > To what extent are $ho and $gho interchangeable? Is it ok to call e.g.
> > get_host_property on a guest (as that function would do).?
> 
> Hrm.  Arguably according to its name, get_host_property should look
> into the $ho->{Host} but it doesn't and that's not what you want here.
> 
> Is whether we should do that a function of the property, or a function
> of the enquiring call site ?  The code at the moment implies the
> former: there is explicit machinery for doing the indirection for
> (e.g.) DhcpWatchMethod.
> 
> I think until we discover otherwise, we can declare that it's fine to
> call get_host_property on a guest object, provided that we understand
> that the answer is always going to be "no such property set".

I'm happy to do that.

> Perhaps this should be documented.

I'll try and remember to slip something in.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel