Re: [Xen-devel] [PATCH v7 2/7] x86: Clear AC bit in RFLAGS to protect Xen itself by SMAP

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.14 at 11:21, <feng.wu@xxxxxxxxx> wrote:
>  ENTRY(early_page_fault)
> -        SAVE_ALL
> +        SAVE_ALL 2

I regret having asked for you doing this tristate conversion, because
passing 2 (and 1 elsewhere) is making this completely meaningless.
Either you use half-way sensible numbers (0 - nothing, 1 - clac,
-1 - stac), or you make this use spelled out strings (so that on use
sites this would look like e.g. "SAVE_ALL CLAC").

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel