Re: [Xen-devel] [RFC] libxc: check return values on mmap() and madvise() on xc_alloc_hypercall_buffer()

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Thu, May 8, 2014 at 3:15 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2014-05-08 at 07:03 +0200, Luis R. Rodriguez wrote:
>> > > BTW I see no ldconfig run after make install, where do we want to put it
>> > > given we have a few libs ?
>>
>> How about this?
>
> Isn't this conventionally the admin's responsibility?

If that is part of the documentation of requirements :)

>> > error cleanup;
>> >
>> >
>> > as it is small enough to do without an out; label.
>>
>> Sure, that makes sesnse.
>
> The out label idiom you have used is pretty conventional and will save
> faff if some other operation gets added here. I'm happy with the patch
> as it is.

OK feel free to take it then.

BTW any idea where in code we get the trigger for what strace picks up as:

1742  write(22, "b", 1)                 = 1

I'm now in a state where instead of b I get "/" written and I just
can't explain this yet.

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel