Re: [Xen-devel] [PATCH v6] Autoconf: add variable for pass arbitrary options to qemu upstream

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-08 at 13:00 +0200, Fabio Fantoni wrote:
> Il 08/05/2014 11:53, Ian Campbell ha scritto:
> > On Tue, 2014-05-06 at 16:30 +0200, Fabio Fantoni wrote:
> >> Added configure options for pass arbitrary build options to qemu
> >> upstream.
> >>
> >> Usage example:
> >> ./configure QEMUU_EXTRA_ARGS="--enable-spice --enable-usb-redir"
> > Isn't
> >          ./configure --with-extra-qemuu-configure-args="--enable-sss"
> > more conventional for this sort of thing?
> 
> I don't know, tell me what is best.

I was asking for input, using an argument seems more normal to me, but I
don't know.

> I must change using AC_ARG_WITH (similar for example to system-seabios 
> part) instead of AC_ARG_VAR?

I haven't looked but that sounds plausible.

> >> diff --git a/config/Tools.mk.in b/config/Tools.mk.in
> >> index 18f3b8a..0693c03 100644
> >> --- a/config/Tools.mk.in
> >> +++ b/config/Tools.mk.in
> >> @@ -55,6 +55,7 @@ CONFIG_QEMU_TRAD    := @qemu_traditional@
> >>   CONFIG_QEMU_XEN     := @qemu_xen@
> >>   CONFIG_BLKTAP1      := @blktap1@
> >>   CONFIG_VTPM         := @vtpm@
> >> +CONFIG_QEMUU_EXTRA_ARGS:= @QEMUU_EXTRA_ARGS@
> > Please insert the word "CONFIGURE" somewhere so we know what the args
> > are for.
> 
> Change it to "+CONFIG_QEMUU_EXTRA_ARGS:= @EXTRA_QEMUU_CONFIGURE_ARGS@
> " can be good or I must change also other parts?

Apart from the code which defines @EXTRA_QEMUU_CONFIGURE_ARGS@ that
would do, I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel