Re: [Xen-devel] [V10 PATCH 3/4] pvh dom0: Add and remove foreign pages

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.05.14 at 14:16, <tim@xxxxxxx> wrote:
> At 16:35 -0700 on 02 May (1399044956), Mukesh Rathor wrote:
>> And, btw, that function, p2m_add_foreign(), went from 
>> 
>> +    if ( (fdid == DOMID_XEN && (fdom = rcu_lock_domain(dom_xen)) == NULL) ||
>> +         (fdid != DOMID_XEN && (fdom = rcu_lock_domain_by_id(fdid)) == 
>> NULL) 
> )
>> +        goto out;
>> 
>> to 
>> 
>> +    fdom = get_pg_owner(foreigndom);
>> 
>> (causing get_pg_owner to be exported) at Jan's comment/suggestion in v8.
> 
> Unless Jan particularly wants to defend that, please don't export
> get_pg_owner().  As I said in the link above it doesn't do what you want
> anyway (e.g around DOMID_IO).

The only reason I suggested using the function was because some other
helper function introduced by the patches mostly re-implemented that
existing one. If it doesn't do what is needed, there's obviously no point
in making it globally accessible.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel