Re: [Xen-devel] [V10 PATCH 3/4] pvh dom0: Add and remove foreign pages

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Thu, 8 May 2014 14:16:50 +0200
Tim Deegan <tim@xxxxxxx> wrote:

> At 16:35 -0700 on 02 May (1399044956), Mukesh Rathor wrote:
> > > Oh yes -- sorry, I got confused between this and the case where
> > > you do use get_pg_owner().  But actually on this subject ISTR
> > > objecting to exporting get_pg_owner() from mm.c before.  Oh yes,
> > > here it is:
> > > 
> > > http://lists.xenproject.org/archives/html/xen-devel/2014-01/msg02612.html
> > > 
> > > So can you use rcu_lock_live_remote_domain_by_id() here instead?
> > 
> > 
> > In p2m_add_foreign() we already get the rcu lock, still do it here? 
> 
> I don't know what you mean by that.  p2m_add_foreign() currently
> implicitly takes the rcu lock by calling get_pg_owner(); I was
> suggecting that you use rcu_lock_live_remote_domain_by_id() instead.

Ok, I can revert p2m_add_foreign() back to calling 
rcu_lock_live_remote_domain_by_id instead of get_pg_owner. I thought
you were referring to page_get_owner in atomic_write_ept_entry().

thanks
mukesh


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel