Re: [Xen-devel] [PATCH v8 2/7] x86: Clear AC bit in RFLAGS to protect Xen itself by SMAP

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.05.14 at 07:34, <feng.wu@xxxxxxxxx> wrote:
> --- a/xen/include/asm-x86/asm_defns.h
> +++ b/xen/include/asm-x86/asm_defns.h
> @@ -190,7 +190,12 @@ static inline void stac(void)
>  #endif
>  
>  #ifdef __ASSEMBLY__
> -.macro SAVE_ALL
> +.macro SAVE_ALL op=0
> +.if \op == CLAC
> +        ASM_CLAC
> +.elseif \op == STAC
> +        ASM_STAC
> +.endif

If this really works with all assembler versions we support, that's of
course fine; I wouldn't have thought this is being accepted by gas.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel