Re: [Xen-devel] [PATCH v7 7/9] ioreq-server: add support for multiple servers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-09 at 09:40 +0100, Paul Durrant wrote:
> Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> ---

An interseries changelog would have been appreciated.

Assuming the hypervisor guys are happy with the hypercal API:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

One minor nit:

> +    if (!pagebuf.nr_ioreq_server_pages ^ !pagebuf.ioreq_server_pfn) {
> +        ERROR("XC_SAVE_ID_HVM_NR_IOREQ_SERVER_PAGES = %"PRIx64" 
> XC_SAVE_ID_HVM_IOREQ_SERVER_PFN = %"PRIx64,
> +              pagebuf.nr_ioreq_server_pages, pagebuf.ioreq_server_pfn);

This is a very long line, and I fear the resulting message will be a bit
meaningless. How about:
        ERROR("Inconsistent IOREQ server settings (pfn=%PRIx64",nr=%"PRIx64")",
               pagebuf....)
?

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel