Re: [Xen-devel] [PATCH v7 7/9] ioreq-server: add support for multiple servers

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Campbell
> Sent: 09 May 2014 10:34
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxx; Ian Jackson; Stefano Stabellini; Jan Beulich
> Subject: Re: [PATCH v7 7/9] ioreq-server: add support for multiple servers
> 
> On Fri, 2014-05-09 at 09:40 +0100, Paul Durrant wrote:
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > Cc: Jan Beulich <jbeulich@xxxxxxxx>
> > ---
> 
> An interseries changelog would have been appreciated.

Sorry, I should have noted exactly which patches had changed.
 
> Assuming the hypervisor guys are happy with the hypercal API:
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 

Thanks.

> One minor nit:
> 
> > +    if (!pagebuf.nr_ioreq_server_pages ^ !pagebuf.ioreq_server_pfn) {
> > +        ERROR("XC_SAVE_ID_HVM_NR_IOREQ_SERVER_PAGES = %"PRIx64"
> XC_SAVE_ID_HVM_IOREQ_SERVER_PFN = %"PRIx64,
> > +              pagebuf.nr_ioreq_server_pages, pagebuf.ioreq_server_pfn);
> 
> This is a very long line, and I fear the resulting message will be a bit
> meaningless. How about:
>         ERROR("Inconsistent IOREQ server settings
> (pfn=%PRIx64",nr=%"PRIx64")",
>                pagebuf....)
> ?
> 

Agreed. I won't rework the series for this. I'll make a note and fix it 
afterwards.

  Paul

> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel