Re: [Xen-devel] [PATCH v4 01/15] xenstore: add support for a retry open limit on xenstored

[Jacek Konieczny <jajcus@xxxxxxxxxx>]

On 05/12/14 16:18, Ian Campbell wrote:
> On Mon, 2014-05-12 at 14:50 +0100, Ian Jackson wrote:
>> Luis R. Rodriguez writes ("[PATCH v4 01/15] xenstore: add support for a 
>> retry open limit on xenstored"):
>>> This adds support for a customizable retry limit on trying to open
>>> the xenstored unix domain socket, each retry is separated by 1 second.
>>> This should allow us to simplify both our LSB init scripts. For systemd
>>> we'll use socket activation.
>>
>> I'm afraid I fundamentally disagree with this timeout/polling based
>> approach.
>
> As for the retry -- I suppose xenstored forks before it is really ready?

I guess this should be fixed in xenstored instead of hacking
work-arounds in the client. When daemon start succeeds then the socket
should be available and working. If it failed, no retry will help. If
the daemon is still starting although the start command exited â than
this sounds like a bug.

Jacek

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel