Re: [Xen-devel] [PATCH v3] hw/passthrough: Prevent QEMU from mapping PCI option ROM at address 0

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.05.14 at 16:37, <malcolm.crossley@xxxxxxxxxx> wrote:
> The PCI option ROM BAR uses the LSB to indicate if the BAR is enabled.
> The AMD graphics driver sets the address bit's of the BAR to 0 but leaves the
> LSB set to 1. Whilst this is not good practice, QEMU should be ignoring the
> non address parts of the BAR.
> 
> This patch adds masking of the bits 0-10 (4k page) parts of the BAR
> before comparing the address to 0.

Sorry, but to avoid confusing (future) readers - this is 2k units, not
4k pages.

> Signed-off-by: Malcolm Crossley <malcolm.crossley@xxxxxxxxxx>

With the description corrected:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel