Re: [Xen-devel] [PATCH v2] xen-blkback: defer freeing blkif to avoid blocking xenwatch

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 12/05/14 20:25, Valentin Priescu wrote:
> From: Valentin Priescu <priescuv@xxxxxxxxxx>
> 
> Currently xenwatch blocks in VBD disconnect, waiting for all pending I/O
> requests to finish. If the VBD is attached to a hot-swappable disk, then
> xenwatch can hang for a long period of time, stalling other watches.
> 
[...]
> 
> With this patch, when there is still pending I/O, the actual disconnect
> is done by the last reference holder (last pending I/O request). In this
> case, xenwatch doesn't block indefinitely.

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

> Signed-off-by: Valentin Priescu <priescuv@xxxxxxxxxx>
> Reviewed-by: Steven Kady <stevkady@xxxxxxxxxx>
> Reviewed-by: Steven Noonan <snoonan@xxxxxxxxxx>
> Acked-by: Matt Wilson <msw@xxxxxxxxxx>

Not sure Acked-by by a non-maintainer makes much sense. Matt, did you
mean Reviewed-by here instead?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel