Re: [Xen-devel] [PATCH V4 09/24] libxl_json: introduce parser functions for builtin types

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 13, 2014 at 12:13:29PM +0100, Ian Campbell wrote:
> On Tue, 2014-05-13 at 12:03 +0100, Wei Liu wrote:
> > On Tue, May 13, 2014 at 11:55:30AM +0100, Ian Campbell wrote:
> > [...]
> > > > And presumably if we are to make this change we also need to update
> > > > libxl.h to have LIBXL_JSON_GENERATE_NUMBER-ish? What would you suggest
> > > > for the name?
> > > 
> > > Does this actually change the output syntax at all? If it is just a bug
> > > fix then we don't need to announce it I think. Any consumers of the JSON
> > > will have to cope with the buggy version (if they want to) irrespective
> > > of any #define.
> > > 
> > 
> > I will need to check. Presumably it generates a string or something.
> 
> Isn't JSON duck typed though? IOW a correct parser should treat {foo: 1}
> and {foo: "1"} the same, if the field foo has numerical semantics?
> 

My initial test shows that for -1 it generates { foo :
18446744073709551615 } which is actually still a number.

So we can safely assume that this is a bugfix. No #define in libxl.h
needed.

> What does libyajl's parser do?
> 

It doesn't seem to be very well documented.

Wei.

> > We can treat it as a bug fix if we only use yajl_gen_number of uint64_t,
> > other uint types are not affect.
> > 
> > Wei.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel