Re: [Xen-devel] [RFC v2 1/6] xen/arm: Save and restore support with hvm context hypercalls

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/13/2014 05:18 PM, Wei Huang wrote:
> Given the comments from you and Andrew, I will revise the context struct
> to the following format. With this, we can get rid of most problems
> (switch/case/...).

With this solution, you will duplicate code to save/restore the timer.

> struct hvm_arm_timer
> {
>     /* phys_timer */
>     uint64_t phys_vtb_offset;
>     uint64_t phys_cval;
>     uint32_t phys_ctl;

If I'm not mistaken, you need a 32 bit padding here ...

> 
>     /* virt_timer */
>     uint64_t virt_vtb_offset;
>     uint64_t virt_cval;
>     uint32_t virt_ctl;

... and here

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel