Re: [Xen-devel] [PATCH v5 01/14] xen/arm: Introduce flush_tlb_domain

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-05-13 at 16:50 +0100, Julien Grall wrote:
> The pattern p2m_load_VTTBR(d) -> flush_tlb -> p2m_load_VTTBR(current->domain)
> is used in few places.
> 
> Replace this usage by flush_tlb_domain which will take care of this pattern.
> This will help to the lisibility of apply_p2m_changes which begin to be big.

"lisibility"? Did you mean to type "visibility"? I think the word you
really wanted was "readability".

> diff --git a/xen/include/asm-arm/flushtlb.h b/xen/include/asm-arm/flushtlb.h
> index 329fbb4..5722c67 100644
> --- a/xen/include/asm-arm/flushtlb.h
> +++ b/xen/include/asm-arm/flushtlb.h
> @@ -25,6 +25,9 @@ do {                                                        
>             \
>  /* Flush specified CPUs' TLBs */
>  void flush_tlb_mask(const cpumask_t *mask);
>  
> +/* Flush CPU's TLBs for the speficied domain */

"Specified"

Other than those two nits:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

If you can confirm what you meant by "lisibility" I can probably fixup
both on commit.

> +void flush_tlb_domain(struct domain *d);
> +
>  #endif /* __ASM_ARM_FLUSHTLB_H__ */
>  /*
>   * Local variables:



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel