Re: [Xen-devel] [RFC v3 4/6] xen/arm: Add save/restore support for guest core registers

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-05-14 at 13:23 +0100, Julien Grall wrote:
> On 05/14/2014 12:16 PM, Ian Campbell wrote:
> > On Sun, 2014-05-11 at 10:06 +0100, Julien Grall wrote:
> >> Hi Wei,
> >>
> >> Thank you for the patch.
> >>
> >> On 08/05/14 22:18, Wei Huang wrote:
> >>> This patch implements a save/resore support for ARM guest core
> >>> registers.
> >>
> >>
> >> The commit 893256f "xen/arm: Correctly save/restore CNTKCTL_EL1" 
> >> save/restore a new register during the context switch.
> >>
> >> I think you forgot to add it in this patch.
> > 
> > I think it would belong in the previous patch with the timer state.
> 
> If Wei plans to use his new structure (see [1]), I'm fine with
> save/restore on the previous patch.
> 
> Otherwise it seems stupid to save twice the same value.

Nobody has suggested saving it twice.

> 
> Regards,
> 
> [1] http://lists.xen.org/archives/html/xen-devel/2014-05/msg01642.html
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel