Re: [Xen-devel] [PATCH 1/4] x86/nmi: remove spurious local_irq_enable from check_nmi_watchdog()

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 14/05/14 14:25, Jan Beulich wrote:
>>>> On 14.05.14 at 14:58, <david.vrabel@xxxxxxxxxx> wrote:
>> All callers of check_nmi_watchdog() already have local irqs enabled so
>> remove the unpaired local_irq_enable().
>>
>> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>> ---
>>  xen/arch/x86/nmi.c |    1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/xen/arch/x86/nmi.c b/xen/arch/x86/nmi.c
>> index 526020b..18d3820 100644
>> --- a/xen/arch/x86/nmi.c
>> +++ b/xen/arch/x86/nmi.c
>> @@ -126,7 +126,6 @@ int __init check_nmi_watchdog (void)
>>  
>>      for_each_online_cpu ( cpu )
>>          prev_nmi_count[cpu] = nmi_count(cpu);
>> -    local_irq_enable();
> 
> I guess this will want to be replaced by a suitable ASSERT(), to make
> sure eventual new callers adhere to the described rule.

smp_call_function() and on_selected_cpus() which is where this matters
already has such an ASSERT() so I don't think another one needs to be
added here.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel