Re: [Xen-devel] [PATCH 1/5] hotplug/linux: Fix the vif script to handle_iptable for tap interfaces

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 14/05/14 11:23, Sylvain Munaut wrote:
> The TAP interfaces need the same iptables rules as the VIF, without it,
> traffic will not be forwarded to/from them is the default FORWARD policy
> is DROP/REJECT
> 
> Signed-off-by: Sylvain Munaut <s.munaut@xxxxxxxxxxxxxxxxxxxx>
> ---
>  tools/hotplug/Linux/vif-bridge    |    2 +-
>  tools/hotplug/Linux/vif-common.sh |    4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/vif-bridge b/tools/hotplug/Linux/vif-bridge
> index b7dcbd6..87279df 100644
> --- a/tools/hotplug/Linux/vif-bridge
> +++ b/tools/hotplug/Linux/vif-bridge
> @@ -97,7 +97,7 @@ case "$command" in
>          ;;
>  esac
>  
> -if [ "$type_if" = vif ]; then
> +if [ "$type_if" = vif -o "$type_if" = tap ]; then

type_if can only be "vif" or "tap" so AFAICT you can drop the if
altogether, the rest looks fine.

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel