Re: [Xen-devel] [PATCH v2] x86: move interrupt entry stubs to entry.S

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: Friday, May 16, 2014 3:35 PM
> To: Wu, Feng
> Cc: Andrew Cooper; keir.xen@xxxxxxxxx; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [PATCH v2] x86: move interrupt entry stubs to entry.S
> 
> >>> On 16.05.14 at 04:12, <feng.wu@xxxxxxxxx> wrote:
> > This patch removes the ugly macros in i8259.c and asm_defns.h, which is
> > used to build up the interrupt entry stubs. Move the definition of these
> > stubs to entry.S instead.
> 
> I suppose you saw that Andrew posted a more comprehensive
> series with, among other things, the same effect as yours. I'm
> clearly tending towards taken his version, unless you can provide
> a good explanation of why yours is preferable.

I didn't notice Andrew's patch. I am okay with that, I did this because
I think this is a subsequent work of the SMAP patch. If Andrew's patch
can do the same thing, I can just stop. Thanks!

Thanks,
Feng

> 
> > --- a/xen/include/asm-x86/asm_defns.h
> > +++ b/xen/include/asm-x86/asm_defns.h
> > @@ -13,6 +13,8 @@
> >
> >  #ifndef __ASSEMBLY__
> >  void ret_from_intr(void);
> > +typedef void (*interrupt_stub_t)(void);
> > +extern const interrupt_stub_t interrupt[];
> 
> I don't see the point of the typedef, and I don't think the declaration
> is well placed in this header.
> 
> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel