Re: [Xen-devel] [PATCH v2] x86: move interrupt entry stubs to entry.S

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.05.14 at 04:12, <feng.wu@xxxxxxxxx> wrote:
> This patch removes the ugly macros in i8259.c and asm_defns.h, which is
> used to build up the interrupt entry stubs. Move the definition of these
> stubs to entry.S instead.

I suppose you saw that Andrew posted a more comprehensive
series with, among other things, the same effect as yours. I'm
clearly tending towards taken his version, unless you can provide
a good explanation of why yours is preferable.

> --- a/xen/include/asm-x86/asm_defns.h
> +++ b/xen/include/asm-x86/asm_defns.h
> @@ -13,6 +13,8 @@
>  
>  #ifndef __ASSEMBLY__
>  void ret_from_intr(void);
> +typedef void (*interrupt_stub_t)(void);
> +extern const interrupt_stub_t interrupt[];

I don't see the point of the typedef, and I don't think the declaration
is well placed in this header.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel