[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v5 7/9] tools: arm: prepare guest FDT building for multiple RAM banks



Julien Grall writes ("Re: [PATCH v5 7/9] tools: arm: prepare guest FDT building 
for multiple RAM banks"):
> On 22/05/14 10:46, Ian Campbell wrote:
> > -    for ( i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> > -    {
> > +    for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ ) {
> 
> We are in libxc, so the previous coding style was valid, i.e:
> for ( ... )
> {

Indeed.  (And the whitespace inside the ( ) might be removed if you
felt like it.)

> Other than this minor change:
> 
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

(Although I haven't gone over this line-by-line.)

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.