Re: [Xen-devel] [PATCH v5 7/9] tools: arm: prepare guest FDT building for multiple RAM banks

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-05-22 at 17:55 +0100, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v5 7/9] tools: arm: prepare guest FDT 
> building for multiple RAM banks"):
> > On 22/05/14 10:46, Ian Campbell wrote:
> > > -    for ( i = 0; rambank_size[i] && i < GUEST_RAM_BANKS; i++ )
> > > -    {
> > > +    for ( i = 0; dom->rambank_size[i] && i < GUEST_RAM_BANKS; i++ ) {
> > 
> > We are in libxc, so the previous coding style was valid, i.e:
> > for ( ... )
> > {
> 
> Indeed.  (And the whitespace inside the ( ) might be removed if you
> felt like it.)

Not in libxc, I think. That follow Xen CODING_STYLE not libxl (why oh
why did we end up making them different...)

> 
> > Other than this minor change:
> > 
> > Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Thanks.

> 
> (Although I haven't gone over this line-by-line.)
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel