Re: [Xen-devel] [V13 PATCH 0/2] pvh dom0 patches...

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 23/05/14 03:35, Mukesh Rathor wrote:
> On Thu, 22 May 2014 20:19:54 +0200
> Roger Pau Monnà <roger.pau@xxxxxxxxxx> wrote:
> 
>> On 22/05/14 19:44, Roger Pau Monnà wrote:
>>> On 20/05/14 01:51, Mukesh Rathor wrote:
>>>> Hi,
>>>>
>>>> Attached please find v13 of dom0 pvh patch series based on 
>>>> c/s: 11dba84.
>>>>
>>>> git tree: git://oss.oracle.com/git/mrathor/xen.git  branch:
>>>> dom0pvh-v13
>>>
>>> I think you forgot to push the series to the git repo (or at least
>>> I'm not able to see branch dom0pvh-v13).
>> Also a Linux branch that works as PVH Dom0 would be interesting to me,
> 
> Hey Roger,
> 
> git://oss.oracle.com/git/mrathor/xen.git  branch: dom0pvh-v15
> git://oss.oracle.com/git/mrathor/linux.git  branch: dom0pvh-1
> 
>> since I've been hitting the vioapic crash when creating HVM guests
> 
> Just apply following patch to get around vioapic crash so you can debug 
> your real ept issue:

Thanks, I think your Linux side patch is missing something like:

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index 8efc066..690b289 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -2533,7 +2533,7 @@ static int xlate_add_to_p2m(unsigned long lpfn,
unsigned long fgmfn,
        set_xen_guest_handle(xatp.errs, &err);

        rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp);
-       return rc;
+       return rc ? : err;
 }

Or else the error value is lost and Linux thinks this page is actually
mapped when it is not, trigger the vioapic crash when trying to access
it. Without this fix I cannot boot HVM domains, with the fix it seems to
be quite stable AFAICT.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel