Re: [Xen-devel] libcacard is been installed to /usr/lib while libdir=/usr/lib64

[Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>]

On 05/21/2014 10:16 AM, Ian Campbell wrote:
> On Wed, 2014-05-21 at 09:52 -0400, Zhigang Wang wrote:
> 
>> Here is my test result with attached patch:
>>
>> 1. qemu_helperdir = libexecdir = $prefix/libexec moves. Affection: 
>> /usr/libexec/qemu-bridge-helper moves to 
>> /usr/lib/xen/libexec/qemu-bridge-helper.
>>
>>      include/net/net.h:#define DEFAULT_BRIDGE_HELPER CONFIG_QEMU_HELPERDIR 
>> "/qemu-bridge-helper"
>>
>>    As the C code already understands this path change, it's not a problem.
>>
>> 2. qemu_confdir = $prefix/etc/qeum moves. Affection: 
>> /usr/etc/qemu/target-x86_64.conf moves to 
>> /usr/lib/xen/etc/qemu/target-x86_64.conf
>>
>>    Also seems the C code understand this path change.
> 
> Agreed. I think /usr/lib/xen/etc/qemu/ is better than e.g. /etc/xen/qemu
> since that might give the impression of affecting the system qemu when
> used with Xen.
> 
> I think both target-86_64.conf and qemu-bridge-helper both don't do very
> much in a Xen system anyway.
> 
>> 3. It seems nothing will conflict with system qemu or qemu-kvm any more.
>>
>> I think it's the right way to go.
> 
> I agree.
> 
> With your change to --prefix I suspect that --libdir and --includedir
> aren't needed, but there's no harm in passing them I suppose.
> 
>> I will do more test and report any issues I find.
> 
> Thanks.

Here is the latest patch: maybe better to put -Wl,-rpath to LDFLAGS instead of 
CFLAGS.

It works well from my CentOS 6 test env.

Please review.

Thanks,

Zhigang

Attachment: xen-tools-qemu-private.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel