Re: [Xen-devel] [PATCH v10 04/11] xl: enable getting and setting soft affinity

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On ven, 2014-06-27 at 14:22 +0100, Ian Campbell wrote:
> On Fri, 2014-06-27 at 15:18 +0200, Dario Faggioli wrote:
> 
> >  That's weird,
> > as I just performed a clean build of that scenario to verify this, and
> > it ended without errors for me.
> > 
> > It's even more strange as the patch contains the hunk below, which is
> > specifically meant at avoiding what you report... :-O
> 
> But strtok_r takes a non-const char *, so when you pass the now const
> cpu to it you get exactly this error, don't you?
> 
Right.

> > --- a/tools/libxl/xl_cmdimpl.c
> > +++ b/tools/libxl/xl_cmdimpl.c
> > @@ -656,7 +656,7 @@ static int update_cpumap_range(const char *str,
> > libxl_bitmap *cpumap)
> >   * single cpus or as eintire NUMA nodes) and turns it into the
> >   * corresponding libxl_bitmap (in cpumap).
> >   */
> > -static int vcpupin_parse(char *cpu, libxl_bitmap *cpumap)
> > +static int vcpupin_parse(const char *cpu, libxl_bitmap *cpumap)
> >  {
> >      char *ptr, *saveptr = NULL;
> >      int rc = 0;
> > 
Yeah, I was looking at this hunk 'backward' mind-tricked by the fact
that it compiles cleanly for me here. :-/

> > Anyway, to be sure, I just compile tested the full series, patch after
> > patch, and that also went well.
> > 
> > I'm not sure what's going on!
> 
> My compiler is stricter than yours?
> 
> I'm building on Debian Wheezy, specifically on the machine "cosworth"
> here in Cambridge. You should have access...
> 
Well, looks like it's strictier, which I find weird, for issues like
this one. I'm building on Debian Sid, with gcc 4.9, which proved
elsewhere to be strictier (see the =NULL in this series, as well as the
blktap2 issue) rather than looser!

Anyway, I'll change this and try with Wheezy's compiler before
resubmitting.

Thanks,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel