[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH ARM v5 18/20] mini-os: import libfdt

On 28/06/14 13:27, Thomas Leonard wrote:
On 28 June 2014 13:01, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
Hi Thomas,

On 26/06/14 12:28, Thomas Leonard wrote:

From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>

Looks like this is revision v1.3.0-47-gbe60268 from

Unfortunately I can find this commit in the git tree. Do you have the full

It works for me:

Hmmm right, sorry for the noise. Even though, you shell command below show a tag but a commit ;).

$ git clone git://git.jdl.com/software/dtc.git
$ cd dtc
$ git show be60268
commit be6026838e45b67800ac803f4ad8cca3cde57d6d
Author: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
Date:   Fri Jun 1 14:12:38 2012 +1000

     libfdt: Add helper function to create a trivial, empty tree

AFAIU, you are using the version 1.3.0, right? If so, why didn't you get the
latest version (i.e 1.4.0)?

I don't know why this particular version was chosen. I could upgrade
it if you want. I don't think there are any functional changes
(uint32_t has been replaced by fdt32_t all over the place, and there
are a couple of extra functions, which we don't need).

Just looking to the libfdt already embedded in xen (xen/common/libfdt) and it looks like we are using the same version.

I'm wondering if you could share the same code and avoid to have the libfdt imported twice in Xen. Any thoughts?


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.