Re: [Xen-devel] [PATCH ARM v5 18/20] mini-os: import libfdt

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

> On 28 Jun 2014, at 16:14, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> 
> 
> 
>> On 28/06/14 13:27, Thomas Leonard wrote:
>>> On 28 June 2014 13:01, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
>>> Hi Thomas,
>>> 
>>> 
>>>> On 26/06/14 12:28, Thomas Leonard wrote:
>>>> 
>>>> From: Karim Raslan <karim.allah.ahmed@xxxxxxxxx>
>>>> 
>>>> Looks like this is revision v1.3.0-47-gbe60268 from
>>>> http://git.jdl.com/gitweb/?p=dtc.git
>>> 
>>> 
>>> Unfortunately I can find this commit in the git tree. Do you have the full
>>> sha1?
>> 
>> It works for me:
> 
> Hmmm right, sorry for the noise. Even though, you shell command below show a 
> tag but a commit ;).
> 
>> $ git clone git://git.jdl.com/software/dtc.git
>> $ cd dtc
>> $ git show be60268
>> commit be6026838e45b67800ac803f4ad8cca3cde57d6d
>> Author: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
>> Date:   Fri Jun 1 14:12:38 2012 +1000
>> 
>>     libfdt: Add helper function to create a trivial, empty tree
>> 
>>> AFAIU, you are using the version 1.3.0, right? If so, why didn't you get the
>>> latest version (i.e 1.4.0)?
>> 
>> I don't know why this particular version was chosen. I could upgrade
>> it if you want. I don't think there are any functional changes
>> (uint32_t has been replaced by fdt32_t all over the place, and there
>> are a couple of extra functions, which we don't need).
> 
> Just looking to the libfdt already embedded in xen (xen/common/libfdt) and it 
> looks like we are using the same version.
> 
> I'm wondering if you could share the same code and avoid to have the libfdt 
> imported twice in Xen. Any thoughts?

MiniOS really needs to be able to compile as a standalone repository and not 
depend on Xen's source code if at all possible. This also came up at the recent 
hackathon in the context of splitting it out of the main repository in the 
future.

-Anil

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel