Re: [Xen-devel] [PATCH 1/2] libxl: Allow multiple serial ports on HVM domain creation

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jul 31, 2014 at 04:31:36PM +0000, White, Edmund H wrote:
> > -----Original Message-----
> > From: Dario Faggioli [mailto:dario.faggioli@xxxxxxxxxx]
> > Sent: Thursday, July 31, 2014 5:58 AM
> > To: White, Edmund H
> > Cc: xen-devel@xxxxxxxxxxxxx; ian.campbell@xxxxxxxxxx;
> > stefano.stabellini@xxxxxxxxxxxxx
> > Subject: Re: [Xen-devel] [PATCH 1/2] libxl: Allow multiple serial ports on 
> > HVM
> > domain creation
> > 
> > On gio, 2014-07-31 at 00:24 +0000, White, Edmund H wrote:
> > 
> > 
> > > diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index
> > > addacdb..0b83ed9 100644
> > > --- a/tools/libxl/libxl_dm.c
> > > +++ b/tools/libxl/libxl_dm.c
> > > @@ -196,8 +196,26 @@ static char **
> > libxl__build_device_model_args_old(libxl__gc *gc,
> > >          int nr_set_cpus = 0;
> > >          char *s;
> > >
> > > -        if (b_info->u.hvm.serial) {
> > > -            flexarray_vappend(dm_args, "-serial", b_info->u.hvm.serial, 
> > > NULL);
> > > +        if (b_info->u.hvm.serial || b_info->u.hvm.serial_list) {
> > > +            if ( b_info->u.hvm.serial && b_info->u.hvm.serial_list )
> > > +            {
> > > +                LOG(ERROR, "%s: Both serial and serial_list set",
> > > +                    __func__);
> > >
> > Looking at LOG-->LIBXL_LOG's definition in tools/libxl/libxl_internal.h, it 
> > looks
> > like __func__ is already included in there, so I don't think you need to 
> > include
> > it explicitly.
> > 
> 
> I simply copied the existing USB device code and changed USB to serial,
> so if this is wrong that's wrong too.
> 

I've sent a patch to remove those "__func__", please remove it from your
patch in you next version.

BTW, you should explicitly CC toolstack maintainers Ian Campbell and Ian
Jackson for your patch.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel