Re: [Xen-devel] [PATCH RFC V6 4/5] xen, libxc: Request page fault injection via libxc

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 12.08.14 at 17:42, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
> On 08/12/2014 06:16 PM, Jan Beulich wrote:
>>>>> On 11.08.14 at 17:08, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>> +    uint64_t virtual_address = 
>>> currd->arch.hvm_domain.fault_info.virtual_address;
>>> +
>>> +    currd->arch.hvm_domain.fault_info.valid = 0;
>>> +
>>> +    if ( currd->arch.hvm_domain.fault_info.write_access )
>>> +        errcode |= PFEC_write_access;
>> 
>> Isn't this pretty limited a set of error codes you're able to generate
>> here?
> 
> For the purpose of simply bringing in pages that the guest OS has
> swapped out for inspection it's been enough.
> 
> I've thought about making this a parameter to the new libxc function,
> but it seems that the PFEC_... codes didn't make it into the public Xen
> headers.

But they're architectural values, so passing just numbers (and
referring to the SDM/PM) would seem fine to me. In which case
you probably wouldn't even need the write_access fields.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel