[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest
Bo Cao writes ("[Xen-devel][PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest"): > This patch exposes a generic interface which can be expanded in the > future to implement USB for DEVICEMODEL. Thanks. Can you arrange to wrap this code to 70-75 characters please ? It currently is very hard to read in my mailreader. > /* generic callback for devices that only need to set ao_complete */ > -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev) > +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev) > { Extern functions must have namespaced names. (libxl__...) I noticed several C++-style // comments. We generally use /* */. That's all I spotted right away. I'll take a proper look when it's less wrap-damaged. Thanks, Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |