Re: [Xen-devel] [PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest

[Simon Cao <caobosimon@xxxxxxxxx>]

On Wed, Aug 13, 2014 at 12:11 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

Bo Cao writes ("[Xen-devel][PATCH v0 RFC 1/2] libxl: Introduce functions in libxl to add and remove USB devices for an PV guest"):

> This patch exposes a generic interface which can be expanded in the
> future to implement USB for DEVICEMODEL.

Thanks. ÂCan you arrange to wrap this code to 70-75 characters
please ? ÂIt currently is very hard to read in my mailreader.

yes, I will wrap that in the next version.

> Â/* generic callback for devices that only need to set ao_complete */
> -static void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
> +void device_addrm_aocomplete(libxl__egc *egc, libxl__ao_device *aodev)
> Â{

Extern functions must have namespaced names. Â(libxl__...)

I have forgotten to modify this back to its original version since I won't need it any more in this patch.

I will modify this in the next version.

I noticed several C++-style // comments. ÂWe generally use /* */.

I will take care of this right away.Â

That's all I spotted right away. ÂI'll take a proper look when it's
less wrap-damaged.

Thanks,
Ian.

Thanks, I will send a renewed version as soon as possible.

Regards,

-Simon

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel