Re: [Xen-devel] [PATCH RFC/WIP 2/4] libxc: treat domain in SHUTDOWN_kexec state as being already suspended

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 25/08/14 14:42, Vitaly Kuznetsov wrote:
> Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
> ---
>  tools/libxc/xc_domain_save.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
> index 42c4752..5423bfa 100644
> --- a/tools/libxc/xc_domain_save.c
> +++ b/tools/libxc/xc_domain_save.c
> @@ -366,7 +366,8 @@ static int suspend_and_state(int (*suspend)(void*), void* 
> data,
>      }
>  
>      if ( (xc_domain_getinfo(xch, dom, 1, info) != 1) ||
> -         !info->shutdown || (info->shutdown_reason != SHUTDOWN_suspend) )
> +         !info->shutdown || ((info->shutdown_reason != SHUTDOWN_suspend) &&
> +                             (info->shutdown_reason != SHUTDOWN_kexec)) )

This will break PV unless you mandate that SHUTDOWN_kexec follows the
same principle as SHUTDOWN_suspend, i.e. stashing the start info mfn in rdx.

Best alter the comment in public/sched.h when adding SHUTDOWN_kexec.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel